Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Mar 31, 2020. It is now read-only.

Slithering Snacks #18

Open
MarkKoz wants to merge 103 commits into python-discord:master
base: master
Choose a base branch
Loading
from chris13888:master
Open

Slithering Snacks #18

MarkKoz wants to merge 103 commits into python-discord:master from chris13888:master

Conversation

@MarkKoz
Copy link
Member

@MarkKoz MarkKoz commented Feb 23, 2019

No description provided.

Copy link

mm

MarkKoz, Transfusion, and chris13888 reacted with confused emoji

MarkKoz and others added 25 commits February 22, 2019 17:35
This configuration will prevent CR from being committed. Qt Creator
is the main culprit here since there is no setting to change its
default line endings.
Include this config using the command:
 git config --local include.path ../.gitconfig
* Replace table widget with a table view
* Rename objects
Python code (project/ui/main_window.py) is generated from
qt/mainwindow.ui using pyside2-uic. Because it is generated, flake8 is
configured to ignore the project/ui directory.
* Add a playlist model for the tree view
An SQLite driver is being used. The database consists of a single table
which has fields for metadata as well as the file's path and CRC32.
ffprobe is used to retrieve metadata in JSON format.
json.loads seems to be able to decode an encoded string just fine, but
this is some added convenience in case `stderr` is to be read.
* Rename add_entry to add_media
* Add docstring to add_media
* Fix linter errors
* Use logging to log the paths for added files
* Fix old add_entry function name being used
* Import media as media_utils instead of ffp
MarkKoz and others added 27 commits March 3, 2019 05:21
* Add millisecond constants for hour, minute, and second
* Remove redundant lambda in signal connection
* Create custom signals for media mutation in Player
* Disable horizontal header highlighting when row is selected
* Remove some debug logging
If it fails, it displays an error and generates a new CAPTCHA.
* Fix password length check
* Ignore B305 flake error
* Use a form layout
* Rename widgets
* Replace the confirm button with a QDialogButtonBox
* Replace display() with open() and exec_() overrides
* Split some behaviour of check() into an override of done()
 * Make check() private
 * Return error messages in check()
 * Set the password and error message in done()
* Clear the inputs and error messages before closing
* Rely on checking result to exit instead of exiting within the class
* Use form layout
* Rename widgets
* Replace the buttons with a QDialogButtonBox
* Replace display() with open() and exec_() overrides
* Split some behaviour of check() into an override of done()
 * Make check() private
 * Set the error message in done()
* Clear the inputs and error messages before closing
* Rely on checking result to exit instead of exiting within the class
* Fix the result of the password prompt being ignored when play is
 pressed
* Switch to a 30% chance for prompt to appear when play is pressed
* Remove "dialog" file references from qmake project file
Copy link
Member

jb3 commented Mar 7, 2019

Fancy project! Documentation in README is great and also inside the files with function docstrings being filled in detail, but it would be nice if all functions could be documented.

Not sure about delegating the jobs off to ffprobe and if you are going to it I'd like to see some comments maybe explaining about what the different flags are for.

Overall code quality is pretty excellent, but you have used a mix of double and single quotes in places.

Copy link
Member Author

MarkKoz commented Mar 7, 2019

I think you are mistaken on the mixed single/double quotes. There is a flake8 plugin in place which would cause the linter to fail if that was the case. I double checked anyway and couldn't find any mixed quotes.

Copy link
Member

jb3 commented Mar 7, 2019

Oh yeah, indeed I was. Apologies about that one!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /