-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
fix(testing): pytest.approx correctly take account Mapping keys order to compare them
#13815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@psf-chronographer
psf-chronographer
bot
added
the
bot:chronographer:provided
(automation) changelog entry is part of PR
label
Oct 15, 2025
...er to compare them
...apping keys order
@cmnemoi
cmnemoi
force-pushed
the
fix/12444
branch
from
October 20, 2025 08:44
1185d0a to
23b8c8e
Compare
Hello @bluetech, can I have a review here ? It should be fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR fixes an issue with
pytest.approxwhere the error message incorrectly reported all elements as mismatched when comparing mappings with different key orders, even when only some values differed.The original code paired values by position rather than by key. This caused incorrect mismatch reporting when dictionary keys were in different orders.
This closes #12444.
Checklist
changelogfolder, named<ISSUE NUMBER>.<TYPE>.rst.