Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

TDynamicDLL as a separate unit + improvements #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
idanmiara wants to merge 2 commits into pyscripter:master from talos-gis:branch_DynamicDLL

Conversation

@idanmiara
Copy link
Contributor

@idanmiara idanmiara commented Dec 6, 2018

I'm using your TDynamicDll as a base for other dlls that I use.
Here are some additions and fixes to make TDynamicDLL more generic

Idan Miara added 2 commits December 6, 2018 14:57
...reateInstance, CreateInstanceAndLoad - creates an instance of the dll + MapDll (abstract virtual), CallMapDll - CallMapDll will be called in AfterLoad + LoadDll - now a function instead of procedure, returns validity. + DoOpenDll - use default dllname if empty string is passed; fix for loading dlls in subdirs (previous method would fail depending on its depended DLLs) + Import now accepts UnicodeStrings + Import2 for handling STDCall on 32bit + DllPath now writes via a function SetDllPath + DllFullFileName added a property that returns the full path of the dll
PythonEngine.pas - TPythonInterface
+ AfterLoad - split functionality between TPythonInterface.MapDll and TDynamicDll.CallMapDll
+ GetDllPath - add the special behavior for the PythonDLL (IsPythonVersionRegistered) which has nothing to do in TDynamicDll
+ MapDll - added functionality from TPythonInterface.GetDllPath; Import now accepts UnicodeString and not AnsiString
Copy link
Contributor Author

Hi,
I'm wondering if you're considering this pull request or should I keep this class in a different repo.
Idan.

Copy link
Owner

I am still pondering about this. I would like to have a closer look to both of your PRs but I have been quite busy. Sorry for taking so long...

Copy link
Contributor Author

idanmiara commented Jan 18, 2019 via email

Ok, thanks.
...
On 2019年1月18日, 02:14 pyscripter ***@***.*** wrote: I am still pondering about this. I would like to have a closer look to both of your PRs but I have been quite busy. Sorry for taking so long... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#65 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AZIQraPmpeuXVzXR-OzXWCtCpMw8WfCiks5vERHJgaJpZM4ZGdab> .

Copy link
Contributor Author

Hi there!
I'm wondering if I should fork DynamicDLL.pas as I'm using it to import a different DLL.
https://github.com/talos-gis/gdal4delphi
Are you still considering this PR?

Copy link
Owner

Feel free to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /