-
-
Couldn't load subscription status.
- Fork 325
WrapDelphi.CreateVarParam with object - a small helpful overload #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WrapDelphi.CreateVarParam with object - a small helpful overload #321
Conversation
Could you please describe a use case or even better a unit test that should pass?
it's not very common - for example, TcxGrid from DevExpress has an event defined as:
TcxGridGetPropertiesEvent = procedure(Sender: TcxCustomGridTableItem; ARecord: TcxCustomGridRecord; var AProperties: TcxCustomEditProperties) of object;
so event handler code use this case of CreateVarParam for passing AProperties to python side
I am happy to merge this, but is it unreasonable to ask to provide a unit test (in WrapDelphiTest.pas) before merging? This would serve as a documentation for users.
you are right, code should be covered by unit tests, I'll prepare sth
finally i added a test for this function - but to take a step forward, this test covers more general event handlers in p4d
... function CreateVarParam(PyDelphiWrapper : TPyDelphiWrapper; AObject: TObject) : PPyObject; overload;