-
-
Couldn't load subscription status.
- Fork 324
Further improvement on packages and demos #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pyscripter
merged 4 commits into
pyscripter:master
from
jr2804:improvements_vcl_projectfiles
Mar 2, 2021
Merged
Further improvement on packages and demos #293
pyscripter
merged 4 commits into
pyscripter:master
from
jr2804:improvements_vcl_projectfiles
Mar 2, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jr2804
Copy link
@jr2804
jr2804
commented
Mar 1, 2021
- added 64-bit support for all packages
- renamed all VCL files to WrapDelphiVcl*.pas
- put them in subfolder vcl & updated project
- Updated demos according to new structure
* renamed all VCL files to WrapDelphiVcl*.pas * put them in subfolder vcl & updated project * Updated demos according to new structure
Good stuff! Thanks!
May I ask for a couple of changes:
// {$include ../Definitions.inc}If the line is not needed just deleted- I prefer WrapVclDialogs instead of WrapDelphiVclDialogs etc. This matches WrapFmxDialogs etc.
Also by "added 64-bit support for all packages" you mean run-time packages, right?
Suggested changes were implemented.
"added 64-bit support for all packages" simply means that 64-bit platform was added in the projects:
image
(only 32-bit was included so far?)
Thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.