-
Notifications
You must be signed in to change notification settings - Fork 313
optimizations in URL implementation #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance Report
Merging #1833 will not alter performance
Comparing dh/url-efficiency (85cc156) with main (1e1c962)
Summary
✅ 163 untouched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the use<..> syntax is only available in Rust 2024.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep we need MSRV 1.82.
There is debate in PyO3 to increase MSRV to 1.83 PyO3/pyo3#5486, so let's just wait on this until 2.13 perhaps.
Change Summary
Generally reduces use of needless
.to_string()calls around the URL code, to avoid temporary strings. Done as a follow up to #1829Related issue number
N/A
Checklist
pydantic-core(except for expected changes)