Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

validate by iteration #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
davidhewitt wants to merge 6 commits into main
base: main
Choose a base branch
Loading
from dh/lookup-tree
Draft

validate by iteration #1620

davidhewitt wants to merge 6 commits into main from dh/lookup-tree

Conversation

@davidhewitt
Copy link
Contributor

@davidhewitt davidhewitt commented Feb 4, 2025

Change Summary

Related to pydantic/jiter#184

By making json object lookup less efficient we should move away from it as much as possible and prefer iteration. We've wanted this anyway for a while as it would be necessary for proper jiter integration.

WIP, I want to introduce a "lookup tree" to handle all the aliases and that madness.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Feb 4, 2025
edited
Loading

CodSpeed Performance Report

Merging #1620 will improve performances by 19.34%

Comparing dh/lookup-tree (306c934) with main (741961c)

Summary

⚡ 1 improvements
✅ 156 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_core_json_fs 134.7 μs 112.9 μs +19.34%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /