Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Document Celery's Distributed Tracing Behaviour #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhruv-ahuja wants to merge 2 commits into pydantic:main
base: main
Choose a base branch
Loading
from dhruv-ahuja:docs/celery_tracing

Conversation

@dhruv-ahuja
Copy link
Contributor

@dhruv-ahuja dhruv-ahuja commented Oct 5, 2025

Creates a dedicated section in the Celery documentation covering the distributed tracing scenario, as discussed in #972.

Copy link

codecov bot commented Oct 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!



if __name__ == "__main__": # (2)!
logfire.configure(service_name="client-app")
Copy link
Contributor

@alexmojaki alexmojaki Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logfire.configure(service_name="client-app")
logfire.configure(service_name="client")

Then this can fit in a screenshot nicely, which should be added

add.delay(42, 50)
```

1. Mark the configuration as running in a distributed tracing environment. This is only required for the worker.
Copy link
Contributor

@alexmojaki alexmojaki Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain in more detail and link to docs.

1. Mark the configuration as running in a distributed tracing environment. This is only required for the worker.
2. Running the file directly will simulate a client application that calls the Celery task.

The keyword arguments of [`logfire.instrument_celery()`][logfire.Logfire.instrument_celery] are passed to the
Copy link
Contributor

@alexmojaki alexmojaki Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to before the installation, it doesn't fit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexmojaki alexmojaki alexmojaki left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /