-
Notifications
You must be signed in to change notification settings - Fork 56
Add function to check if nodes are reachable via bolt #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4f4a9cd to
ae080f1
Compare
8e43b1c to
aededbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not peadm specific and I think other plans could benefit from it as well. But I'm not sure which module would be a good place for such a generic function. I think bolt has no generic module where we could add it? Maybe stdlib or extlib are good candidates?
aededbd to
45e9f27
Compare
functions/check_availability.pp
Outdated
@jay7x
jay7x
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this I meant above:
fail_plan('Some targets are not reachable', 'peadm/unreachable-nodes', error_set => $check_result.error_set)
@jay7x
jay7x
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is missing:
expect_plan('peadm::check_availability')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bastelfreak this too
45e9f27 to
e38f823
Compare
At the moment the plans assume that all nodes are available. I had a few customer setups where one of the compilers wasn't reachable during a convert/upgrade. To not put the PE infra into an undefined state, it makes sense to check the availability before running the plans.
e38f823 to
9cf675c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bastelfreak I was chatting to our Docs and he has suggested this change for the messaging;
Bolt cannot reach the following targets: target1@example.com, target2@example.com
<installation conversion upgrade> cannot be continued
Exiting
Is it possible to update it like this?
Hey @bastelfreak just wondering if you got a chance to check out the comments I left? Thanks 😃
Hey @bastelfreak this PR is stall, can you please follow up with all comments?
At the moment the plans assume that all nodes are available. I had a few customer setups where one of the compilers wasn't reachable during a convert/upgrade. To not put the PE infra into an undefined state, it makes sense to check the availability before running the plans.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?