-
Notifications
You must be signed in to change notification settings - Fork 5
105 Add more flexible "module_acceptance_custom.yml" #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As for validity, it is tested in the field with migration of module https://github.com/puppetlabs/puppetlabs-servicenow_cmdb_integration , with success.
#105 (comment)
@sooyean-hoo
sooyean-hoo
force-pushed
the
105-for-githubworkflowsmodule_acceptanceyml-can-we-have-a-version-which-does-not-hardcoded-to-all-the-litmus-tasks-this-makes-it-harder-to-update-some-of-old-modules-whose-dependencies-vary-a-lot
branch
from
September 4, 2024 04:46
69d673b to
e982609
Compare
FYI, I have my own tests running against my own forked version. https://github.com/sooyean-hoo/cat-github-actions/blob/dev_sooyean/.github/workflows/module_acceptance_custom.yml
This is where all the results above come from .
@sooyean-hoo
sooyean-hoo
force-pushed
the
105-for-githubworkflowsmodule_acceptanceyml-can-we-have-a-version-which-does-not-hardcoded-to-all-the-litmus-tasks-this-makes-it-harder-to-update-some-of-old-modules-whose-dependencies-vary-a-lot
branch
from
September 4, 2024 05:12
e982609 to
566e31e
Compare
@sooyean-hoo
sooyean-hoo
force-pushed
the
105-for-githubworkflowsmodule_acceptanceyml-can-we-have-a-version-which-does-not-hardcoded-to-all-the-litmus-tasks-this-makes-it-harder-to-update-some-of-old-modules-whose-dependencies-vary-a-lot
branch
from
September 5, 2024 04:12
566e31e to
26d60a2
Compare
@sooyean-hoo
sooyean-hoo
changed the title
(削除) 105 for githubworkflowsmodule acceptanceyml can we have a version which does not hardcoded to all the litmus tasks this makes it harder to update some of old modules whose dependencies vary a lot (削除ここまで)
(追記) 105 for "module acceptance.yml" can we have a version which does not hardcoded to all the litmus tasks this makes it harder to update some of old modules whose dependencies vary a lot (追記ここまで)
Sep 6, 2024
@sooyean-hoo
sooyean-hoo
changed the title
(削除) 105 for "module acceptance.yml" can we have a version which does not hardcoded to all the litmus tasks this makes it harder to update some of old modules whose dependencies vary a lot (削除ここまで)
(追記) 105 for "module_acceptance.yml" can we have a version which does not hardcoded to all the litmus tasks this makes it harder to update some of old modules whose dependencies vary a lot (追記ここまで)
Sep 6, 2024
@sooyean-hoo
sooyean-hoo
changed the title
(削除) 105 for "module_acceptance.yml" can we have a version which does not hardcoded to all the litmus tasks this makes it harder to update some of old modules whose dependencies vary a lot (削除ここまで)
(追記) 105 Add "module_acceptance.yml" which allows for more flexible use cases. (追記ここまで)
Sep 11, 2024
@sooyean-hoo
sooyean-hoo
changed the title
(削除) 105 Add "module_acceptance.yml" which allows for more flexible use cases. (削除ここまで)
(追記) 105 Add "module_acceptance_custom.yml" which allows for more flexible use cases. (追記ここまで)
Sep 11, 2024
generated by matrix_from_metadata_v2 Add new custom workflow Add in a new input: matrix_from_metadata default to matrix_from_metadata_v2 Clean up some spaces in *custom.yaml Signed-off-by: Hoo Sooyean (何書淵) <Sooyean.hoo@perforce.com> Fix a mistake of the task name
@sooyean-hoo
sooyean-hoo
force-pushed
the
105-for-githubworkflowsmodule_acceptanceyml-can-we-have-a-version-which-does-not-hardcoded-to-all-the-litmus-tasks-this-makes-it-harder-to-update-some-of-old-modules-whose-dependencies-vary-a-lot
branch
from
October 1, 2024 05:23
26d60a2 to
4c42b4c
Compare
@sooyean-hoo
sooyean-hoo
changed the title
(削除) 105 Add "module_acceptance_custom.yml" which allows for more flexible use cases. (削除ここまで)
(追記) 105 Add more flexible "module_acceptance_custom.yml" (追記ここまで)
Oct 1, 2024
@puppetlabs/modules think this needs looked as we are not entirely sure about the best approach to move forward with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Addressing problem or issue in #105 .
For .github/workflows/module_acceptance.yml, can we have a version which does not hardcoded to all the Litmus Tasks? This makes it harder to update some of old modules, whose dependencies/implementation/styles vary a lot.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
#105
#103 - This included as also for continuity, as it is also on the same theme and for the same approach.
Checklist