Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix LDAP login page by using internal static resources rather than ex... #4416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fmartinou wants to merge 1 commit into provectus:master
base: master
Choose a base branch
Loading
from fmartinou:fix/#4178

Conversation

@fmartinou
Copy link

@fmartinou fmartinou commented Mar 21, 2024

  • Breaking change?

What changes did you make? (Give an overview)
The LDAP login page was loading css (bootstrap and signin from external CDN instead of using the local resources).
It already has been fixed for the Basic Auth login page but not the LDAP login page.

How Has This Been Tested?

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@fmartinou fmartinou requested a review from a team as a code owner March 21, 2024 18:10
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there fmartinou! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@fmartinou fmartinou mentioned this pull request Mar 21, 2024
2 tasks
Copy link

vishaldhanani commented Jan 27, 2025 •
edited
Loading

Hi, I'm facing the same issue using the latest tag "main" & "v1.1.0" images and it's not showing anything after login to the LDAP type "group". It's working fine with "v1.0.0" image but not sure what's causing on the latest images. Does anyone have documented how to resolve this issue? Looking forward to hearing to resolve it! Appreciate your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /