-
-
Couldn't load subscription status.
- Fork 1.6k
Adding new About.Contact (missing) translation and merging About localization keys, for en-US and pt-BR locales
#3693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...localization keys, for `en-US` and `pt-BR` locales
Please notice the original Contact localization key had no translation at all, in any of the locales, including the default one (en-US). I renamed it to About.Contact, due to the fact that it is primarily used in the About page.
I also found out that the About key itself had 2 (identical) translation entries/keys: Nav.Help.About and About.Title. So I decided to merge both into the 2nd one.
...g-about-localization-keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for catching this and following up with the changes so promptly!
Fixes #3692
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123