-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Placing donate button text update in useEffect hook
#3668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
raclim
merged 3 commits into
processing:develop
from
cassiano:placing-donate-button-text-update-logic-in-use-effect-hook
Oct 2, 2025
Merged
Placing donate button text update in useEffect hook
#3668
raclim
merged 3 commits into
processing:develop
from
cassiano:placing-donate-button-text-update-logic-in-use-effect-hook
Oct 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also increased the timeout to 500 ms, for precaution, and placed the donation logo image URL in a constant, avoiding repetition and keeping the code DRY.
...ve the `t()` function, since it is probably stable)
...n-use-effect-hook
raclim
raclim
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this! Giving a heads up here that the current fundraiser will be up until Oct. 14.
@cassiano
cassiano
deleted the
placing-donate-button-text-update-logic-in-use-effect-hook
branch
October 2, 2025 17:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3667
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123