Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Displaying p5.js version in About page #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@cassiano
Copy link
Contributor

@cassiano cassiano commented Sep 26, 2025 •
edited by raclim
Loading

Fixes: #3663

Displaying p5.js version in About page

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named
  • meets the standards outlined in the accessibility guidelines

Copy link
Contributor Author

Before:

image

After:

image

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this, this looks good to me!

I also just want to note that the our software projects are trying to follow the precedent (listed in the contributor docs) where all pull requests should be associated with an open issue, and the issue should ideally be assigned to the contributor! I went ahead with creating and attaching it here since this has been identified for a while, but it would be great if you could create one for the other PRs here as well!

Thanks again and please let me know if you have any questions!

cassiano reacted with thumbs up emoji
@raclim raclim merged commit 3ba269a into processing:develop Sep 26, 2025
1 check passed
@cassiano cassiano deleted the displaying-p5js-version-in-about-page branch October 4, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

p5.js Version Number Not Visible in About Page

2 participants

AltStyle によって変換されたページ (->オリジナル) /