-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Banner for Messaging + Announcements #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
49 changes: 49 additions & 0 deletions
client/modules/IDE/components/Banner.jsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import React from 'react'; | ||
| import PropTypes from 'prop-types'; | ||
| import { CrossIcon } from '../../../common/icons'; | ||
|
|
||
| /** | ||
| * Banner displays a dismissible announcement bar with a link and a close icon. | ||
| * It's typically used to highlight opportunities, but use and design can be flexible. | ||
| * | ||
| * This component is **presentational only** — visibility logic (open/close state) should be | ||
| * controlled by the parent via the `onClose` handler. | ||
| * | ||
| * @param {Object} props | ||
| * @param {function} props.onClose - Function called when the user clicks the close (✕) button | ||
| * @returns {JSX.Element} The banner component with a call-to-action link and a close button | ||
| * | ||
| * @example | ||
| * const [showBanner, setShowBanner] = useState(true); | ||
| * | ||
| * {showBanner && ( | ||
| * <Banner onClose={() => setShowBanner(false)} /> | ||
| * )} | ||
| */ | ||
|
|
||
| const Banner = ({ onClose }) => { | ||
| // URL can be updated depending on the opportunity or announcement. | ||
| const bannerURL = 'https://openprocessing.org/curation/89576'; | ||
| const bannerCopy = ( | ||
| <> | ||
| We’re accepting p5.js sketches for a special curation exploring the new | ||
| features in p5.js 2.0!{' '} | ||
| <span style={{ fontWeight: 600 }}>Submit by July 13!</span> | ||
| </> | ||
| ); | ||
|
|
||
| return ( | ||
| <div className="banner"> | ||
| <a href={bannerURL}>{bannerCopy}</a> | ||
| <button className="banner-close-button" onClick={onClose}> | ||
| <CrossIcon /> | ||
| </button> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| Banner.propTypes = { | ||
| onClose: PropTypes.func.isRequired | ||
| }; | ||
|
|
||
| export default Banner; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
client/styles/components/_banner.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| .banner { | ||
| width: 100%; | ||
| min-height: 2.2rem; | ||
| text-align: center; | ||
| padding: 1rem; | ||
| background-color: #DFED33; // yellow from p5.js website | ||
| border-bottom: 1px solid #000; | ||
|
|
||
| a { | ||
| color: #000; | ||
| } | ||
|
|
||
| a:hover { | ||
| text-decoration: underline; | ||
| } | ||
|
|
||
| @media (max-width: 770px) { | ||
| min-height: 3.3rem; | ||
| } | ||
| } | ||
|
|
||
| .banner-close-button { | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| justify-content: center; | ||
| height: 20px; | ||
| width:20px; | ||
| float: right; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.