Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Turkish Translations #2182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raclim merged 6 commits into processing:develop from cemergin:turkish_translations
Apr 19, 2023
Merged

Conversation

@cemergin
Copy link
Contributor

@cemergin cemergin commented Mar 24, 2023
edited
Loading

Adds Turkish translations to the editor client.

Process Details:

  • Rough translations were first done by Chat GPT3.5
  • Personally (a Native Turkish speaker, living in the US) went over each line to see if anything sounds unnatural or silly.
  • Did some manual testing to see if it works as expected
  • Ran lint & tests
  • Voila!

Issue Here

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptive name

Screen Shot 2023年03月23日 at 9 45 52 PM

Screen Shot 2023年03月23日 at 9 45 48 PM

Screen Shot 2023年03月23日 at 9 45 31 PM

Screen Shot 2023年03月23日 at 9 44 09 PM

d and links to an issue number, i.e.

omertarikkoc reacted with hooray emoji
Copy link

welcome bot commented Mar 24, 2023

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Collaborator

PR-wise this looks great, thank you!

I cannot vouch for the validity of the translations as I don't know Turkish, but I doubt we can find a reviewer who does 🤷 @raclim what's the process for approving new translations?

Copy link

I am also a native Turkish speaker and I can vouch for the translations.

lindapaiste, cemergin, and raclim reacted with heart emoji

@raclim raclim added the Create Release Environment For use with ReleaseHub ephemeral environments label Apr 14, 2023
@raclim raclim added Create Release Environment For use with ReleaseHub ephemeral environments and removed Create Release Environment For use with ReleaseHub ephemeral environments labels Apr 14, 2023
@raclim raclim added Create Release Environment For use with ReleaseHub ephemeral environments and removed Create Release Environment For use with ReleaseHub ephemeral environments labels Apr 18, 2023
Copy link
Collaborator

raclim commented Apr 18, 2023

@lindapaiste There probably could be a more organized way to facilitate this, but I believe that our process so far has been to validate any incoming translations from another native speaker (thanks @omertarikkoc 🙂)!

Thank you so much @cemergin for providing your translation process, I also think it looks great so far! One last change I would suggest adding is to also include Turkish into the Navigation dropdown when you have the chance.

Copy link
Contributor Author

cemergin commented Apr 19, 2023
edited
Loading

Hey @raclim! Great callout, forgot to add that. My last commit should handle it.

You can reach out to me for the maintenance or updates to the Turkish translations.

raclim reacted with hooray emoji

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much! :)

@raclim raclim merged commit d247600 into processing:develop Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raclim raclim raclim approved these changes

Assignees

No one assigned

Labels

Create Release Environment For use with ReleaseHub ephemeral environments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /