Commit f4140aa

author

Arseny Kositsyn

committed

[PGPRO-11599] Code review. Part 4.

Tags: rum

1 parent 1693779 commit f4140aaCopy full SHA for f4140aa

File tree

+14

-7

lines changed

+14

-7

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,9 @@ This module is available under the [license](LICENSE) similar to`
`41`	`41`
`42`	`42`	`Before building and installing rum, you should ensure following are installed:`
`43`	`43`
`44`		`-* PostgreSQL version is 9.6+.`
	`44`	`+* PostgreSQL version is 12+.`
	`45`	`+`
	`46`	+* PostgreSQL 9.6 - 11 (but you need to transfer the `src/backend/nodes/tidbitmap.c` of the required version to the `contrib/rum/src/tidbitmap/tidbitmapXX.c` and include it to `contrib/rum/src/rumtidbitmap.c`)
`45`	`47`
`46`	`48`	`Typical installation procedure may look like this:`
`47`	`49`

Lines changed: 11 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,18 +14,23 @@`
`14`	`14`
`15`	`15`	`#include "rumtidbitmap.h"`
`16`	`16`
	`17`	`+/*`
	`18`	`+ * NOTE: For compatibility with PostgreSQL versions less than 12,`
	`19`	`+ * you need to transfer the src/backend/nodes/tidbitmap.c of the`
	`20`	`+ * required version to the RUM and include it here.`
	`21`	`+ */`
`17`	`22`	`#if PG_VERSION_NUM >= 170000`
`18`		`-#include "tidbitmap17.c"`
	`23`	`+#include "tidbitmap/tidbitmap17.c"`
`19`	`24`	`#elif PG_VERSION_NUM >= 160000`
`20`		`-#include "tidbitmap16.c"`
	`25`	`+#include "tidbitmap/tidbitmap16.c"`
`21`	`26`	`#elif PG_VERSION_NUM >= 150000`
`22`		`-#include "tidbitmap15.c"`
	`27`	`+#include "tidbitmap/tidbitmap15.c"`
`23`	`28`	`#elif PG_VERSION_NUM >= 140000`
`24`		`-#include "tidbitmap14.c"`
	`29`	`+#include "tidbitmap/tidbitmap14.c"`
`25`	`30`	`#elif PG_VERSION_NUM >= 130000`
`26`		`-#include "tidbitmap13.c"`
	`31`	`+#include "tidbitmap/tidbitmap13.c"`
`27`	`32`	`#elif PG_VERSION_NUM >= 120000`
`28`		`-#include "tidbitmap12.c"`
	`33`	`+#include "tidbitmap/tidbitmap12.c"`
`29`	`34`	`#endif`
`30`	`35`
`31`	`36`	`RumTIDBitmap *`