Commit 1693779

author

Arseny Kositsyn

committed

[PGPRO-11599] Code review. Part 3.

Tags: rum

1 parent 168f856 commit 1693779Copy full SHA for 1693779

File tree

1 file changed

+27

-3

lines changed

src
- rumget.c

1 file changed

+27

-3

lines changed

`‎src/rumget.c‎`

Lines changed: 27 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -760,6 +760,13 @@ scan_entry_cmp(const void p1, const void p2, void *arg)`
`760`	`760`	`return -cmpEntries(arg, e1, e2);`
`761`	`761`	`}`
`762`	`762`
	`763`	`+/*`
	`764`	`+ * The entryGetItem() function write the results to curItem in a specific`
	`765`	`+ * order. The function below allow you to understand the order in which the`
	`766`	`+ * results will be returned. This is important in a multi-column RUM index,`
	`767`	`+ * when the results will be returned in different order for different subquery`
	`768`	`+ * conditions.`
	`769`	`+ */`
`763`	`770`	`static bool`
`764`	`771`	`isScanWithAltOrderKeys(RumScanOpaque so)`
`765`	`772`	`{`
`@@ -1622,7 +1629,12 @@ scanGetItemRegular(IndexScanDesc scan, RumItem *advancePast,`
`1622`	`1629`	`{`
`1623`	`1630`	`RumScanEntry entry = so->entries[i];`
`1624`	`1631`
`1625`		`- /* In the case of scanning with altOrderKeys, skip the usual keys */`
	`1632`	`+ /*`
	`1633`	`+ * In the case of scanning with altOrderKeys, skip the usual keys.`
	`1634`	`+ *`
	`1635`	`+ * Note: so->scanWithAltOrderKeys can only be true if`
	`1636`	`+ * rumstate->useAlternativeOrder is true`
	`1637`	`+ */`
`1626`	`1638`	`if (so->scanWithAltOrderKeys &&`
`1627`	`1639`	`rumstate->attrnAddToColumn != entry->attnumOrig)`
`1628`	`1640`	`continue;`
`@@ -1661,7 +1673,13 @@ scanGetItemRegular(IndexScanDesc scan, RumItem *advancePast,`
`1661`	`1673`	`RumScanKey key = so->keys[i];`
`1662`	`1674`	`int cmp;`
`1663`	`1675`
`1664`		`- /* In the case of scanning with altOrderKeys, skip the usual keys */`
	`1676`	`+ /*`
	`1677`	`+ * Skip orderBy keys or in the case of scanning with altOrderKeys,`
	`1678`	`+ * skip the usual keys.`
	`1679`	`+ *`
	`1680`	`+ * Note: so->scanWithAltOrderKeys can only be true if`
	`1681`	`+ * rumstate->useAlternativeOrder is true`
	`1682`	`+ */`
`1665`	`1683`	`if (key->orderBy \|\| (so->scanWithAltOrderKeys &&`
`1666`	`1684`	`rumstate->attrnAddToColumn != so->keys[i]->attnumOrig))`
`1667`	`1685`	`continue;`
`@@ -1692,7 +1710,13 @@ scanGetItemRegular(IndexScanDesc scan, RumItem *advancePast,`
`1692`	`1710`	`{`
`1693`	`1711`	`RumScanKey key = so->keys[i];`
`1694`	`1712`
`1695`		`- /* In the case of scanning with altOrderKeys, skip the usual keys */`
	`1713`	`+ /*`
	`1714`	`+ * Skip orderBy keys or in the case of scanning with altOrderKeys,`
	`1715`	`+ * skip the usual keys.`
	`1716`	`+ *`
	`1717`	`+ * Note: so->scanWithAltOrderKeys can only be true if`
	`1718`	`+ * rumstate->useAlternativeOrder is true`
	`1719`	`+ */`
`1696`	`1720`	`if (key->orderBy \|\| (so->scanWithAltOrderKeys &&`
`1697`	`1721`	`rumstate->attrnAddToColumn != so->keys[i]->attnumOrig))`
`1698`	`1722`	`continue;`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 1693779

File tree

1 file changed

1 file changed

`‎src/rumget.c‎`

0 commit comments