- 
  Notifications
 
You must be signed in to change notification settings  - Fork 125
 
fix: Fix ref as prop causing circular reference in useMemo in React 19 #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
 
  Open
 
 
 Conversation
 
 
 This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
 Learn more about bidirectional Unicode characters
 
 
 
 
 
 
 
 Sign up for free
 to join this conversation on GitHub.
 Already have an account?
 Sign in to comment
 
 
 Add this suggestion to a batch that can be applied as a single commit.
 This suggestion is invalid because no changes were made to the code.
 Suggestions cannot be applied while the pull request is closed.
 Suggestions cannot be applied while viewing a subset of changes.
 Only one suggestion per line can be applied in a batch.
 Add this suggestion to a batch that can be applied as a single commit.
 Applying suggestions on deleted lines is not supported.
 You must change the existing code in this line in order to create a valid suggestion.
 Outdated suggestions cannot be applied.
 This suggestion has been applied or marked resolved.
 Suggestions cannot be applied from pending reviews.
 Suggestions cannot be applied on multi-line comments.
 Suggestions cannot be applied while the pull request is queued to merge.
 Suggestion cannot be applied right now. Please check back later.
 
 
 
 
Uh oh!
There was an error while loading. Please reload this page.
Description
Starting React 19, refs passed as props
This caused the
wrapEffectfunction to not work anymore as the ref ended up being passed accidentally as a dependency ofuseMemocausing a circular reference issue.Not sure what's the overall strategy regarding backwards compatibility with React 18.x, and whether any future version of @react-three dependencies plan on supporting older versions of React. Let me know / feel free to adjust this PR based on that.
How to reproduce the issue
wrapEffector using a custom effect withwrapEffectwrapEffect-> you should see the circular reference issue and the scene will not render anymoreHow was it tested
Forked the repo and tested the fix for this function by moving it into my own repo with my own custom effect example
Note: As this package still relies on yarn and all my project are on pnpm, I was not able to do further testing building the package locally and linking it.
Issues this addresses
Fixes: