Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Use native legends when converting from matplotlib #5312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 3 commits into plotly:main from robertoffmoura:rm/use-native-legend
Oct 1, 2025

Conversation

@robertoffmoura
Copy link
Contributor

@robertoffmoura robertoffmoura commented Aug 8, 2025

Use native legends (showlegend = true) instead of recreating them using shapes and annotations.

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@gvwilson gvwilson added P1 needed for current cycle community community contribution fix fixes something broken labels Aug 11, 2025
Copy link
Contributor

emilykl commented Aug 11, 2025

Thank you for the contribution @robertoffmoura ! This is great.

Could you run ruff format on the modified files and commit the changes, so that the code_formatting CI job will pass?

(There's a failure in build as well but that one looks unrelated to this PR.)

Copy link
Contributor Author

Thanks, Emily! Done, just pushed a new commit after running ruff format.

Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again @robertoffmoura 🚀

@emilykl emilykl merged commit aa4c088 into plotly:main Oct 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilykl emilykl emilykl approved these changes

Labels

community community contribution fix fixes something broken P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /