-
-
Couldn't load subscription status.
- Fork 2.7k
fix: Resolve issue causing extraneous engine deprecation warnings
#5287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes the issue in #5286
I don't believe any docstrings need updating as the ones for the classes/methods I changed do not reference the default for the engine argument. The default was also changed to None further up the API. I believe this should basically be a NOP for most users/flows. If this warrants a change in the CHANGELOG, please let me know. I figured for the above reasons it did not.
engine deprecation warnings (追記ここまで)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for running this down @jdbeel, this is great.
I agree, this should be a noop since inside the to_image function, engine is set to "auto" if None is passed.
Once the engine argument is removed from the to_image and write_image functions, we should remove it from these functions as well. Until then this is a good solution.
🚀
Code PR
plotly.graph_objects, my modifications concern the code generator and not the generated files.