Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support setting plotly.js path for Kaleido v1 image export #5207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilykl merged 5 commits into main from support-setting-plotlyjs-path
Jun 3, 2025

Conversation

@emilykl
Copy link
Contributor

@emilykl emilykl commented May 27, 2025
edited
Loading

Closes #5206

  • Adds a pio.defaults.plotlyjs entry for setting the Plotly.js path
  • Makes sure the value of pio.defaults.plotlyjs is passed through to Kaleido when using Kaleido v1

@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken labels May 28, 2025
Copy link
Contributor

@emilykl LGTM

@emilykl emilykl force-pushed the support-setting-plotlyjs-path branch from 7047c7c to 6837831 Compare May 29, 2025 19:25
@emilykl emilykl force-pushed the support-setting-plotlyjs-path branch from d066330 to f0aba76 Compare June 2, 2025 20:23
Copy link
Contributor Author

emilykl commented Jun 3, 2025

FYI @gvwilson @ayjayt this is ready to merge except that I need to update the Kaleido RC version referenced in pyproject.toml since rc13 is no longer compatible — once a newer RC is available on PyPI I will update this branch and then merge.

Copy link
Contributor

gvwilson commented Jun 3, 2025

thank you

@emilykl emilykl merged commit 3afcd45 into main Jun 3, 2025
10 checks passed
@gvwilson gvwilson deleted the support-setting-plotlyjs-path branch June 4, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gvwilson gvwilson gvwilson approved these changes

Reviewers whose approvals may not affect merge requirements

Labels

fix fixes something broken P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Manually setting Plotly.js path is not possible with Kaleido v1

AltStyle によって変換されたページ (->オリジナル) /