Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix 5186 type checking renegerate code #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvwilson merged 3 commits into main from fix-5186-type-checking-renegerate-code
May 27, 2025

Conversation

@gvwilson
Copy link
Contributor

@gvwilson gvwilson commented May 22, 2025

@gvwilson gvwilson requested a review from emilykl May 22, 2025 18:59
@gvwilson gvwilson self-assigned this May 22, 2025
@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken regression this used to work labels May 22, 2025
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Confirming that this seems to fix syntax highlighting in VSCode on my machine.

gvwilson added 2 commits May 25, 2025 08:43 
- Restore code removed in #4978.
- (Partially) closes #5186.
- Remove unneeded imports of `sys`.
- Restore code removed in #4978.
- Add `test_path.png` to `.gitignore`.
- Closes #5186.
@gvwilson gvwilson force-pushed the fix-5186-type-checking-renegerate-code branch from 848f68e to 44907a3 Compare May 25, 2025 12:48
Copy link
Contributor Author

updated to remove sys imports and check again version 3.7

Copy link

kszlim commented May 27, 2025

I'm curious if there will be a (relatively quick) patch version released once this makes it in?

Copy link
Contributor Author

@kszlim coming soon
kszlim reacted with hooray emoji

@gvwilson gvwilson merged commit 7bc7ce5 into main May 27, 2025
10 checks passed
@gvwilson gvwilson deleted the fix-5186-type-checking-renegerate-code branch June 4, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilykl emilykl emilykl approved these changes

Labels

fix fixes something broken P1 needed for current cycle regression this used to work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /