Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Merge test and tests folder and clean up files #5023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marthacryan merged 2 commits into master from update-test-dir
Feb 10, 2025
Merged

Conversation

@marthacryan
Copy link
Collaborator

@marthacryan marthacryan commented Feb 10, 2025

  • Removes test/vv
  • Moves test/percy to tests/percy to consolidate test directories
    • Updates .gitignore and circle CI config to point to new location of percy directory

Copy link
Contributor

emilykl commented Feb 10, 2025

@marthacryan IMO -- move the existing tests which were inside tests/ into tests/unit/ so that we have

tests/
 - percy/
 - unit/
 - test_core/ 
 - etc. 

Not strictly necessary because it seems like pytest tests/ "just works" and skips the percy/ dir anyway, but I think it would be ideal to have a directory which contains only the Pytest tests in case we need it.

Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marthacryan marthacryan merged commit 3ddf627 into master Feb 10, 2025
5 checks passed
@marthacryan marthacryan deleted the update-test-dir branch February 10, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilykl emilykl emilykl approved these changes

@gvwilson gvwilson Awaiting requested review from gvwilson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /