Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Unpin test requirements #5019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marthacryan merged 47 commits into main from unpin-requirements
Mar 6, 2025
Merged

Unpin test requirements #5019

marthacryan merged 47 commits into main from unpin-requirements
Mar 6, 2025

Conversation

@marthacryan
Copy link
Collaborator

@marthacryan marthacryan commented Feb 7, 2025 •
edited
Loading

  • Replaces the separated files which pinned different versions of packages for each version of python with two files that list the unpinned requirements for core / optional tests
  • Updates the CI config to be more parameterized
  • Removes the no numpy tests - it turns out that it wasn't actually testing without numpy, and since we added narwhals our tests do in fact fail without numpy
  • Removes orca tests from config
  • Adds uv into a couple of more spots to speed up the dependency downloads
  • Removes unused commit step from plotly.js dev build job
  • Removes unused import of ipython and sage salvus in plotly/tools.py

@gvwilson gvwilson added feature something new P1 needed for current cycle dependencies Pull requests that update a dependency file labels Feb 10, 2025
@marthacryan marthacryan marked this pull request as ready for review February 11, 2025 21:49
Copy link
Contributor

@emilykl emilykl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marthacryan LGTM once my final comments are addressed! 🚀

This is a huge win for maintainability.

A few big-picture thoughts that could be addressed in another PR:

  • IMO we should bring back the no-numpy job (to prevent numpy dependency from accidentally slipping into core Plotly.py)

  • If we're testing pandas<2 with Python 3.9, should we also test pandas<2 for other Python versions? Probably worth a discussion.

@marthacryan marthacryan merged commit 2799251 into main Mar 6, 2025
5 checks passed
@marthacryan marthacryan deleted the unpin-requirements branch March 6, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiamConnors LiamConnors LiamConnors left review comments

@emilykl emilykl emilykl approved these changes

Labels

dependencies Pull requests that update a dependency file feature something new P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /