-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Acepace remove future #4951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Acepace remove future #4951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The future is now, has been now for quite a few years Signed-off-by: Ace Pace <acepace@gmail.com>
Plotly supports only 3.8 and up Signed-off-by: Ace Pace <acepace@gmail.com>
This is never imported or used Signed-off-by: Ace Pace <acepace@gmail.com>
@emilykl can you please have a look at this as part of the plotly.py repo cleanup work?
acepaceNS
commented
Mar 18, 2025
Can anyone check on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some dead code, starting with the low hanging fruit mentioned in #4817
Playing around with the zip imports but it's not PR ready yet.