-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
fix: pandas DataFrame with non-default Index was resulting in scrambled data in scatter_matrix #4921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data in scatter_matrix
@gvwilson
gvwilson
added
community
community contribution
fix
fixes something broken
labels
Dec 1, 2024
emilykl
emilykl
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, @MarcoGorelli. Sorry for the delayed review, I wanted to take the time to make sure I understood the differences between the Pandas and Narwhals index behavior. Looks good! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
These issue get closed "for free" with the latest Narwhals release, as a result of narwhals-dev/narwhals#1474 having been addressed:
DataFramewith a scrambled index andcolorinpx.scatter_matrix()yields mismatched/null colors #4788colorand non-sorted index #3576Furthermore, it allows for the Plotly codebase to be simplified a bit, as
maybe_reset_indexisn't necessary any more. So, I've:Demo:
Latest stable plotly release:
image
This branch:
image