-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Modify template generator to automatically add new map traces and subplots
#4881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
See #4879 for discussion. 1. Move material from `packages/python/plotly/templategen/__init__.py` to new file `packages/python/plotly/templategen/__main__.py` so that we can run `python -m templategen` from the `packages/python/plotly` directory. 2. Modify `packages/python/plotly/templategen/utils/__init__.py` to change `heatmapgl` reference to `heatmap`. 3. Run `python -m templategen` to generate new versions of the following files: - `packages/python/plotly/plotly/package_data/templates/ggplot2.json` - `packages/python/plotly/plotly/package_data/templates/plotly.json` - `packages/python/plotly/plotly/package_data/templates/plotly_dark.json` - `packages/python/plotly/plotly/package_data/templates/plotly_white.json` - `packages/python/plotly/plotly/package_data/templates/seaborn.json` - `packages/python/plotly/plotly/package_data/templates/simple_white.json`
does this replace #4880 ?
The only way I can think of to test the templates themselves is to add something that parses the JSON and looks at the structure, but I don't think that would add much value, since it would basically be cloning the generator code.
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Resolves #4879.
See #4879 for discussion.
packages/python/plotly/templategen/__init__.pyto new filepackages/python/plotly/templategen/__main__.pyso that we can runpython -m templategenfrom thepackages/python/plotlydirectory.packages/python/plotly/templategen/utils/__init__.pyto changeheatmapglreference toheatmap.python -m templategento generate new versions of the following files:packages/python/plotly/plotly/package_data/templates/ggplot2.jsonpackages/python/plotly/plotly/package_data/templates/plotly.jsonpackages/python/plotly/plotly/package_data/templates/plotly_dark.jsonpackages/python/plotly/plotly/package_data/templates/plotly_white.jsonpackages/python/plotly/plotly/package_data/templates/seaborn.jsonpackages/python/plotly/plotly/package_data/templates/simple_white.json