-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Do not assign offsetgroup to traces in px unless barmode="group"
#4865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Unfortunately, not using Without See comparison below — I believe the behavior on
|
offsetgroup to traces in px unless barmode="grouped" (追記ここまで)
offsetgroup to traces in px unless barmode="grouped" (削除ここまで)offsetgroup to traces in px unless barmode="group" (追記ここまで)
Note: The 4 visual changes in Percy are the 4 charts which were incorrect on master and are now returning to how they should look.
thanks @emilykl - @marthacryan please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.
Closes #4863
This change is required due to the change in behavior for
offsetgroupintroduced in Plotly.js 3.0: plotly/plotly.js#7009The above change causes bars to appear as a group if
offsetgroupis set, even ifbarmodeis set tostacked, which changes the default behavior of histograms and bar charts, as explained in #4863 (see comment).This PR fixes the issue by only setting
offsetgroupifbarmode="group". (We also setoffsetgroupifbarmodeis not set, sincegroupis the default barmode in Plotly.js.)Note that we can't remove setting
offsetgroupentirely due to the issue described in my comment here.The other change (changing the point at which we set
barmodetooverlayif the figure has marginal histograms) is so that the figure'sbarmodein that case will be set before the point where we decide whether to setoffsetgroup.