-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Remove tenacity dependency #4831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
alexcjohnson
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Love it!
@ndrezn
ndrezn
force-pushed
the
remove-tenacity
branch
from
October 24, 2024 15:28
4aca07f to
7b6cfe8
Compare
Please mention this PR in the change log.
Thank you!
@gvwilson
gvwilson
added
feature
something new
P1
needed for current cycle
dependencies
Pull requests that update a dependency file
labels
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The
tenacitydependency in Plotly.py (added in #2911) is used today in one place for Orca to provide a pretty naive retry decorator. It's easy enough to write our own with identical functionality.This means it's possible to remove the sole dependency of Plotly.py. Yay!
The meaningful change is in cf4bfd1