Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed show_edges and renamed dist_func to color_func #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kully merged 1 commit into master from trisurf_fixes
May 25, 2016
Merged

Conversation

@Kully
Copy link
Contributor

@Kully Kully commented May 25, 2016

Copy link
Contributor

awesome - now we just need to wait on that lighting fix. I'll make a tiny
package to wrap some of the "activity" plots in high-level functions.

On Wed, May 25, 2016 at 10:59 AM, Adam Kulidjian notifications@github.com
wrote:

@choldgraf https://github.com/choldgraf

You can view, comment on, or merge this pull request online at:

#482
Commit Summary

  • Fixed show_edges and renamed dist_func to color_func

File Changes

Patch Links:


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#482

Copy link
Contributor Author

Kully commented May 25, 2016

awesome - now we just need to wait on that lighting fix. I'll make a tiny
package to wrap some of the "activity" plots in high-level functions.

Okay. Shall I merge then?

Copy link
Contributor

I'm +1 on merge. I'll work with what's here a little bit and see if
anything comes up.

Chris

Sent from my phone, apologies for the curtness and type-os
On May 25, 2016 11:21 AM, "Adam Kulidjian" notifications@github.com wrote:

awesome - now we just need to wait on that lighting fix. I'll make a tiny
package to wrap some of the "activity" plots in high-level functions.

Okay. Shall I merge then?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#482 (comment)

@Kully Kully merged commit 1935cf1 into master May 25, 2016
@Kully Kully deleted the trisurf_fixes branch May 25, 2016 18:43
Copy link
Contributor

🍻

Copy link
Contributor

I'm getting some weird behavior now (working off the latest master). calling iplot now doesn't do anything...it looks to output something, but no plot is ever shown. It looks like something along these lines was changed recently...is anybody else experiencing this? @Kully @theengineear

Copy link
Contributor

weird, I tried it on another computer and now it works fine. maybe my browser crashed on the other one

Copy link

empet commented May 25, 2016

@choldgraf There was/is a bug in plotly.js that stops displaying a plot when plotly.offline.init_notebook_mode() is run twice. During the last week the plotly.js team worked on this issue.
To check that your browser is working OK, just replace the line of code
plotly.offline.iplot(fig) with plotly.offline.plot(fig, filename='your-file.html).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /