-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Convert base64 in BaseFigure.to_dict instead of validate_coerce #4784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Converting to base64 in validate_coerce_fig_to_dict offers the same performance improvements without changing the output of the data field of the Figure object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a stray debugging statement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Nice discovery! Thanks to @marthacryan and @emilykl
PR of the year! 🏆 🏅 🌟
This would simplify the changes made to the tests and validation steps on the #4470 PR.
💃
Uh oh!
There was an error while loading. Please reload this page.
Converting to base64 in BaseFigure.to_dict() offers the same performance improvements without changing the output of the data field of the Figure object. This will only be called through
show()or in dash