Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update percy tests to use maps #4743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LiamConnors merged 4 commits into master from update-percy-tests
Sep 19, 2024
Merged

Update percy tests to use maps #4743

LiamConnors merged 4 commits into master from update-percy-tests
Sep 19, 2024

Conversation

@LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Aug 30, 2024

No description provided.

@LiamConnors LiamConnors changed the title (削除) Update percy tests (削除ここまで) (追記) Update percy tests to use maps (追記ここまで) Aug 30, 2024
Copy link
Contributor

archmoj commented Aug 30, 2024

Do we set unused plot config on any of these?

Copy link
Member Author

LiamConnors commented Aug 30, 2024
edited
Loading

Do we set unused plot config on any of these?

I don't understand. Do you have an example of what this looks like? And what's the impact of setting/not setting it for these tests?

Copy link
Contributor

archmoj commented Aug 30, 2024

Do we set unused plot config on any of these?

I don't understand. Do you have an example of what this looks like? And what's the impact of setting/not setting it for these tests?

I mean if you search inside these tests any of them using set mapbox token?

Copy link
Member Author

Do we set unused plot config on any of these?

I don't understand. Do you have an example of what this looks like? And what's the impact of setting/not setting it for these tests?

I mean if you search inside these tests any of them using set mapbox token?

None of the tests are using that.

archmoj reacted with thumbs up emoji

Copy link
Contributor

archmoj commented Aug 30, 2024

Thanks. Wondering why some tests are failing?

@gvwilson gvwilson added P2 considered for next cycle fix fixes something broken labels Sep 3, 2024
@LiamConnors LiamConnors merged commit 673c19c into master Sep 19, 2024
3 of 5 checks passed
@LiamConnors LiamConnors deleted the update-percy-tests branch September 19, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@archmoj archmoj Awaiting requested review from archmoj

1 more reviewer

@gvwilson gvwilson gvwilson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix fixes something broken P2 considered for next cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /