-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix CI failure #4728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failure #4728
Conversation
I suggest @LiamConnors should review : ) Removing my assignment (though code changes look OK to me in general)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the fix.
Looking good to me.
@LiamConnors Wondering this might be something we should also add to the release process?
💃
Thanks very much for the fix. Looking good to me. @LiamConnors Wondering this might be something we should also add to the release process?
💃
@archmoj which part of the release process might benefit from adding something based on this? I thought this PR fixes it
Thanks very much for the fix. Looking good to me. @LiamConnors Wondering this might be something we should also add to the release process?
💃@archmoj which part of the release process might benefit from adding something based on this? I thought this PR fixes it
Just in case you noticed a similar bug during the release.
Fixes the failing CI based on suggestions in this comment.