-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add tests for the keys that should be skipped in base64 conversion #4727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/python/plotly/plotly/tests/test_optional/test_graph_objs/test_skipped_b64_keys.py
Outdated
Show resolved
Hide resolved
packages/python/plotly/plotly/tests/test_optional/test_graph_objs/test_skipped_b64_keys.py
Outdated
Show resolved
Hide resolved
packages/python/plotly/plotly/tests/test_optional/test_graph_objs/test_skipped_b64_keys.py
Outdated
Show resolved
Hide resolved
...bjs/test_skipped_b64_keys.py Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
Any change to refactor it?
Are there any other data types that we need to put this condition in specially for ranges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any change to refactor it?
Just pushed a change! Let me know if you have naming or other refactoring suggestions :)
Are there any other data types that we need to put this condition in specially for ranges?
So, this is the only place that calls to_typed_array_spec, so I think that should cover any conversions that are happening. Does that answer your question?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this to do if it is done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR and bug fix.
💃
Uh oh!
There was an error while loading. Please reload this page.
Adds tests for #4470 to test that certain keys are not being converted to the { base64, dtype } object. These keys were found here. Geojson shouldn't be converted because it would then be an invalid geojson object.