-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Handle extras option in IntegerValidator
#4612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@LiamConnors please merge this PR once you added a changelog regarding the changes, etc. as required.
Thank you very much in advance 🙏
Logic looks good to me. Thanks @archmoj !
Do we have tests for the validators? Can we add a test for this change?
Logic looks good to me. Thanks @archmoj !
Do we have tests for the validators? Can we add a test for this change?
Good call.
It would be nice to add tests for this PR.
@LiamConnors you may add a test in packages/python/plotly/_plotly_utils/tests/validators/test_dash_validator.py
Thank you!
@LiamConnors The tests used to pass before your commit which simply added a line to the changelog. But now it fails.
Do you have any idea why this is happening?
I'll add tests in a separate PR later.
extrasare added to plotly.js integer validator in plotly/plotly.js@37dee48i.e. to handle cases like bold and normal in
font.weightwhich could also be a number between 1-1000.This commit would be required in updating to upcoming plotly.js v2.33.0.
@LiamConnors
cc: @emilykl @gvwilson