-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Consider necessary columns from complex arguments when interchanging dataframes #4324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/python/plotly/plotly/tests/test_optional/test_px/test_px_input.py
Show resolved
Hide resolved
9aa93e3 to
e2a7cb4
Compare
Thanks so much @guyrosin ! Would you add a changelog entry, in a new ## UNRELEASED section at the top? Then I think this is ready to go, and we'll try to get a patch out shortly.
Done. That's great to hear! Thanks @alexcjohnson for the feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Very nice! Thanks again for identifying AND fixing this regression @guyrosin
This PR fixes a regression from #4286, where only plain string arguments were considered as necessary columns when interchanging dataframes. This PR considers complex arguments as well (such as
hover_data).For example, running the code below resulted in
ValueError: Value of 'hover_data_0' is not the name of a column in 'data_frame'. Expected one of ['petal_length', 'sepal_length'] but received: speciesplotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).