Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update plotlyjs version to 2.22.0 and update docs #4165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LiamConnors merged 12 commits into master from update-plotlyjs-docs
May 8, 2023

Conversation

@LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Apr 18, 2023
edited
Loading

  • Add examples for texttemplate on shapes
  • Add example for multiple legends

Documentation PR

  • I've seen the doc/README.md file
  • This change runs in the current version of Plotly on PyPI and targets the doc-prod branch OR it targets the master branch
  • If this PR modifies the first example in a page or adds a new one, it is a px example if at all possible
  • Every new/modified example has a descriptive title and motivating sentence or paragraph
  • Every new/modified example is independently runnable
  • Every new/modified example is optimized for short line count and focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized
  • Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible
  • The random seed is set if using randomly-generated data in new/modified examples
  • New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets
  • Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations
  • Imports are plotly.graph_objects as go / plotly.express as px / plotly.io as pio
  • Data frames are always called df
  • fig = <something> call is high up in each new/modified example (either px.<something> or make_subplots or go.Figure)
  • Liberal use is made of fig.add_* and fig.update_* rather than go.Figure(data=..., layout=...) in every new/modified example
  • Specific adders and updaters like fig.add_shape and fig.update_xaxes are used instead of big fig.update_layout calls in every new/modified example
  • fig.show() is at the end of each new/modified example
  • plotly.plot() and plotly.iplot() are not used in any new/modified example
  • Hex codes for colors are not used in any new/modified example in favour of these nice ones

Copy link
Member Author

Encountering this issue when trying to build locally #4166
and the build fails here and has the same error

@LiamConnors LiamConnors changed the title (削除) Update plotlyjs version (削除ここまで) (追記) Update plotlyjs version to 2.22.0 and update docs (追記ここまで) Apr 27, 2023
@LiamConnors LiamConnors marked this pull request as ready for review April 27, 2023 18:00
Copy link
Member Author

LiamConnors commented Apr 27, 2023
edited
Loading

Still haven't figured out the failing tests for the release build, but the docs content is ready for review

@archmoj

Copy link
Contributor

archmoj commented May 2, 2023

Still haven't figured out the failing tests for the release build, but the docs content is ready for review

@archmoj

The docs are looking good.
Concerning the plotly.py build failure we should possibly ask @alexcjohnson and @nicolaskruchten for help 🆘

LiamConnors reacted with thumbs up emoji

Copy link
Collaborator

hmph looks like it might just be an out-of-date node. This repo still has the circleci/python images, it's really beyond time to update to cimg/python, I'll try to make a new PR to do that.

Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@LiamConnors LiamConnors merged commit 49c4c02 into master May 8, 2023
@LiamConnors LiamConnors deleted the update-plotlyjs-docs branch May 8, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

@nicolaskruchten nicolaskruchten Awaiting requested review from nicolaskruchten

@archmoj archmoj Awaiting requested review from archmoj

@Coding-with-Adam Coding-with-Adam Awaiting requested review from Coding-with-Adam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /