-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Doc - Configuration-options - improvement propositions #3861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LiamConnors
merged 1 commit into
plotly:doc-prod
from
sdidier-dev:doc-configuration-options-patch
Jun 9, 2023
Merged
Doc - Configuration-options - improvement propositions #3861
LiamConnors
merged 1 commit into
plotly:doc-prod
from
sdidier-dev:doc-configuration-options-patch
Jun 9, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nicolaskruchten
nicolaskruchten
force-pushed
the
doc-prod
branch
from
January 14, 2023 02:16
1a182ff to
cbe41e6
Compare
LiamConnors
LiamConnors
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here some improvement propositions as I am going through the docs:
Add missing
fig.show()in second exemple of Removing Modebar Buttons and Add optional shape-drawing buttons to modebarModify
config = dict({'scrollZoom': True})toconfig = {'scrollZoom': True}in Enabling Scroll ZoomRemove unused
import plotly.graph_objects as goin the two examples in Add optional shape-drawing buttons to modebarRemove #L6 from hyperlink https://github.com/plotly/plotly.js/blob/master/src/plot_api/plot_config.js#L6 in Reference
(nothing special on line 6)
Add/remove spaces and new lines for syntax and consistency
Documentation PR
doc/README.mdfiledoc-prodbranch OR it targets themasterbranchpxexample if at all possibleplotly.graph_objects as go/plotly.express as px/plotly.io as piodffig = <something>call is high up in each new/modified example (eitherpx.<something>ormake_subplotsorgo.Figure)fig.add_*andfig.update_*rather thango.Figure(data=..., layout=...)in every new/modified examplefig.add_shapeandfig.update_xaxesare used instead of bigfig.update_layoutcalls in every new/modified examplefig.show()is at the end of each new/modified exampleplotly.plot()andplotly.iplot()are not used in any new/modified example