Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add Dash Club snippet #3839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LiamConnors merged 6 commits into doc-prod from add-dashclub
Oct 4, 2022
Merged

Add Dash Club snippet #3839

LiamConnors merged 6 commits into doc-prod from add-dashclub
Oct 4, 2022

Conversation

@LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Aug 9, 2022

@Coding-with-Adam, as requested, this adds the Dash Club snippet that we already have on the Dash docs. Adds it to the ten most popular pages here to get started.

@LiamConnors LiamConnors changed the base branch from master to doc-prod August 9, 2022 18:39
Copy link
Contributor

Hi @LiamConnors
is the goal to start with only 10 pages and then put the dash club snippet in more pages if it works?

Copy link
Contributor

Can I see a screenshot/mockup of what you're trying to do with this? There may be an easier site-wide way of doing this.

Copy link
Member Author

LiamConnors commented Aug 11, 2022
edited
Loading

@nicolaskruchten sure. It's the snippet that we already have in the Dash docs. Like on this page:
https://dash.plotly.com/introduction

image

And we want to put it on the top 100 pages, near the Dash content on those pages.

Copy link
Contributor

@LiamConnors can you please share a screenshot of what this looks like in the docs.

Copy link
Member Author

@Coding-with-Adam it looks like this:

image

We could also maybe instead add it to the What About Dash section at the end of each page?

image

As What About Dash is just one Markdown file that's added to each page when it's being built, it would be much quicker to get this snippet appearing on all pages and would be much easier to manage when we want to make changes.

@LiamConnors LiamConnors marked this pull request as draft August 30, 2022 17:14
Copy link
Contributor

Hi @LiamConnors,
I'm afraid that having the snippet at the very bottom of the page would limit the amount of eyes on it, as very few people scroll all the way down.

When you say "it would be much quicker to get this snippet appearing on all pages", you mean that having the snippet outside the What About Dash markdown file would slow the page load time? If so, do we have the tools to test the page loading speed?

Copy link
Member Author

@Coding-with-Adam, apologies, I meant it would be easier to implement and maintain. I see your point about it being too far down the page. What do you think about having it just below the Dash app example?

If we were put it below the Dash app example, maybe we could just add it to the Dash Snippet app itself. Do you see any issues with that approach @nicolaskruchten? I couldn't see any other straightforward way to implement this across the site. But if we add it to the app container (assuming that placement is okay with @Coding-with-Adam) we'd only have to update it in one place to get it on all those pages that have a Dash app.

Copy link
Contributor

Hi @LiamConnors

  1. Yes, I think so. Are you suggesting we add the snippet to the code section itself or right above it?

  2. In the "join now" section, can you please use this link that Jiny created with the UTM: https://go.plotly.com/dash-club?utm_source=Dash+Club+2022&utm_medium=graphing_libraries&utm_content=inline

  3. Can you please update the snippet to say: "Free cheat sheets plus..." instead of "Two free cheat sheets plus...". We just added another two cheat sheets to the list, so they will be getting multiple.

Copy link
Member Author

Hi @LiamConnors

  1. Yes, I think so. Are you suggesting we add the snippet to the code section itself or right above it?

@Coding-with-Adam, I was thinking right below the running example

  1. In the "join now" section, can you please use this link that Jiny created with the UTM: https://go.plotly.com/dash-club?utm_source=Dash+Club+2022&utm_medium=graphing_libraries&utm_content=inline

Updated

  1. Can you please update the snippet to say: "Free cheat sheets plus..." instead of "Two free cheat sheets plus...". We just added another two cheat sheets to the list, so they will be getting multiple.

Updated

I've added the snippet to the pages that have Dash examples. It looks like this:

image

For pages that don't have a Dash example or mention of Dash, where do you think it should go?

Copy link
Contributor

Thank you @LiamConnors . We're good to go. I just talked to Chris and he liked the placement and wording as well.
💃🏻
Could we also update the script from "2+ cheat sheets" to "multiple cheat sheets" in the Dash docs dash club snippet?

@LiamConnors LiamConnors marked this pull request as ready for review September 6, 2022 17:23
Copy link
Member

@chriddyp chriddyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃🏼

@LiamConnors LiamConnors merged commit 6166ada into doc-prod Oct 4, 2022
@archmoj archmoj deleted the add-dashclub branch March 22, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chriddyp chriddyp chriddyp approved these changes

@nicolaskruchten nicolaskruchten Awaiting requested review from nicolaskruchten

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /