-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Smoothing being applied in the "unnoised" data #3628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The smoothening was being applied in y, and not in y_noise. That makes no sense.
@nicolaskruchten
nicolaskruchten
force-pushed
the
doc-prod
branch
from
January 14, 2023 02:16
1a182ff to
cbe41e6
Compare
@gvwilson
gvwilson
changed the title
(削除) Smoothening being applied in the "unnoised" data (削除ここまで)
(追記) Smoothing being applied in the "unnoised" data (追記ここまで)
Aug 12, 2024
@gvwilson
gvwilson
added
P2
considered for next cycle
fix
fixes something broken
labels
Aug 12, 2024
@alexcjohnson can you please tell me if the commit comment makes sense?
alexcjohnson
alexcjohnson
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @mateomontero01 - and apologies for not noticing your PR earlier! Yes of course, the whole point here is what this filter does to noisy data, not to the underlying smooth curve. 💃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoothening was being applied in y, and not in y_noise. That makes no sense.