Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

added function create_annotated_heatmap_of_categorical_data to create... #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tejas-Gosavi wants to merge 1 commit into plotly:master from Tejas-Gosavi:master

Conversation

@Tejas-Gosavi
Copy link

@Tejas-Gosavi Tejas-Gosavi commented Apr 13, 2021

... annotated heatmap of categorical data from DateFrame and individual series objects

This is my first PR request, that's why i am little bit of nervous and afraid.

If there are any mistakes then tell me i will definately clear those mistakes.

Please uncomment this block and take a look at this checklist if your PR is making substantial changes to documentation/impacts files in the doc directory. Check all that apply to your PR, and leave the rest unchecked to discuss with your reviewer! Not all boxes must be checked for every PR :)

If your PR modifies code of the plotly package, we have a different checklist
below :-).

Documentation PR

  • I've seen the doc/README.md file
  • This change runs in the current version of Plotly on PyPI and targets the doc-prod branch OR it targets the master branch
  • If this PR modifies the first example in a page or adds a new one, it is a px example if at all possible
  • Every new/modified example has a descriptive title and motivating sentence or paragraph
  • Every new/modified example is independently runnable
  • Every new/modified example is optimized for short line count and focuses on the Plotly/visualization-related aspects of the example rather than the computation required to produce the data being visualized
  • Meaningful/relatable datasets are used for all new examples instead of randomly-generated data where possible
  • The random seed is set if using randomly-generated data in new/modified examples
  • New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets
  • Large computations are avoided in the new/modified examples in favour of loading remote datasets that represent the output of such computations
  • Imports are plotly.graph_objects as go / plotly.express as px / plotly.io as pio
  • Data frames are always called df
  • fig = <something> call is high up in each new/modified example (either px.<something> or make_subplots or go.Figure)
  • Liberal use is made of fig.add_* and fig.update_* rather than go.Figure(data=..., layout=...) in every new/modified example
  • Specific adders and updaters like fig.add_shape and fig.update_xaxes are used instead of big fig.update_layout calls in every new/modified example
  • fig.show() is at the end of each new/modified example
  • plotly.plot() and plotly.iplot() are not used in any new/modified example
  • Hex codes for colors are not used in any new/modified example in favour of these nice ones

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

... annotated heatmap of categorical data from DateFrame and individual series objects
Copy link
Contributor

Thanks for this PR! I'll try to find time to review it in the next couple of weeks :)

Tejas-Gosavi reacted with thumbs up emoji

Copy link
Contributor

OK, I'm finally reviewing this :)

Can you provide a bit of context around the need for this new factory? Is what you're trying to do not possible with any of the existing functions we have? I'm not sure about the use-case here...

Copy link
Author

Tejas-Gosavi commented Jun 7, 2021
edited
Loading

@nicolaskruchten first sorry for this late replay to you, by coming on main point what this function do is that when given two
columns having unique values less than 20, it plots count of unique values of first column with respect to unique values of second column, it is little bit hard for me to explain to you but i have written an example in that factory file from line 43, plz
check and run code with that example, i know you will definately understand from that, so plz run that code.

@gvwilson gvwilson self-assigned this Jun 25, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added feature something new P2 considered for next cycle community community contribution labels Aug 12, 2024
Copy link
Contributor

@Tejas-Gosavi thank you again for submitting this - I'm very sorry it's taken us so long to get to it, but we are no longer enhancing figure factory, so I'm going to close this one as stale. Best regards - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

community community contribution feature something new P2 considered for next cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /