-
-
Couldn't load subscription status.
- Fork 2.7k
Dendrogram andrew tweaks #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Conflicts: plotly/tools.py
The difficulty of comparing dicts with nested either (a) ndarrays or (b) number arrays that equal one another up-to-a-tolerance was preventing us from writing stronger tests. This is far from perfect, but it allows you to just throw a set of dict objects in without getting false negative results.
...python-api into dendrogram-andrew-tweaks Conflicts: plotly/tests/test_optional/test_opt_tracefactory.py
I think this was likely the intent?
@OxanaSachenkova , I mostly did some re-arranging and I tried to strengthen the test suite by always checking the full objects that get returned from your code-paths.
Mind giving the tests a look to make sure they're as expected?
looks good to me! can you add whatever ipython notebook that you've been using to test-run this package to the documentation repo when it's merged? you'll just need to add one line to the end of the notebook that describes the URL, etc. See here for an example: https://github.com/plotly/documentation/blob/source/_posts/python/finance/candlestick-charts.ipynb
@chriddyp will do! just need to polish it up a bit, quite messy right now
Can we 💃 on it?
💃
Thanks again @OxanaSachenkova !
Hey @cldougl Could add some dendrogram examples to the Python docs when you have some free time? I want to get these into next month's blog posts.
@theengineear @chriddyp
not sure the dendrograms are still embedding in notebooks correctly http://nbviewer.ipython.org/gist/cldougl/cfdffaf7b8b0185af552 (unless I'm doing something wrong but they're fine not embedded https://plot.ly/~chelsea_lyn/7664 ).
@cldougl - can you try moving the height and width into the layout and out
of iplot?
On Tue, Oct 20, 2015 at 3:46 PM, Chelsea notifications@github.com wrote:
@theengineear https://github.com/theengineear @chriddyp
https://github.com/chriddyp
not sure the dendrograms are still embedding in notebooks correctly
http://nbviewer.ipython.org/gist/cldougl/cfdffaf7b8b0185af552 (unless I'm
doing something wrong but they're fine not embedded
https://plot.ly/~chelsea_lyn/7664 ).—
Reply to this email directly or view it on GitHub
#312 (comment).
Chris Parmer
Plotly, Chief Product Officer
514 571 5897
https://plot.ly/team
yep that works- I'll update the examples in the docstring
This is based off of @OxanaSachenkova 's branch, which added
Dendrogramplots \o/\o/\o/Todo: