Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

add optionial gzip compression in html export #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mickare wants to merge 3 commits into plotly:master from mickare:html_compression
Closed

add optionial gzip compression in html export #3117

mickare wants to merge 3 commits into plotly:master from mickare:html_compression

Conversation

@mickare
Copy link

@mickare mickare commented Mar 18, 2021
edited
Loading

Exporting big 3d meshes resulted in huge files since the data is stored as plain text in the html file. By storing the data in compressed base64 the file size can be reduced by 85%.

Reduction Examples:
96.8mb to 15.4mb
42.2mb to 2.7mb
27.6mb to 6.8mb

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • For a new feature, I have added documentation examples in an existing or
    new tutorial notebook (please see the doc checklist as well).
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.
  • For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).

mickare added 3 commits March 18, 2021 17:49
Exporting big 3d meshes resulted in huge files since the data is stored as plain text in the html file. By storing the data in compressed base64 the file size can be reduced by 85%.
Reduction Examples:
 96.8mb to 15.4mb
 42.2mb to 2.7mb
 27.6mb to 6.8mb
Copy link
Contributor

Thanks for this pull request! We will try to review it in the coming month for inclusion in the upcoming v5.0 of this library :)

mickare reacted with thumbs up emoji

Copy link
Contributor

Sorry for the delay in reviewing this... I'm a bit hesitant to accept this PR because it adds a dependency on another Javascript library which tends to add maintenance work as security vulnerabilities are found etc etc. We're looking at ways to encode large numerical arrays as base64-encoded binary data soon, which should go a long way towards reducing file sizes in cases like the above, without needing to ungzip in the browser like this.

@gvwilson gvwilson self-assigned this Jun 25, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@gvwilson gvwilson added feature something new P2 considered for next cycle community community contribution labels Aug 12, 2024
Copy link
Author

mickare commented Aug 16, 2024

Closing long-time open PRs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

community community contribution feature something new P2 considered for next cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /