-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add Quiver and Streamline Functions #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Quiver function plots velocity vectors and Streamline function plots streamlines with directional arrows
plotly/tools.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't make numpy a dependency. check out how we do "protected" imports of pandas to get around this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alternatively, rewrite the numpy functionality in pure python!
clean up
draft of tests
Quiver: can plot 1 arrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job on all the examples \o/
@cldougl Got some more comments for ya! The highest-priority stuff is related to test coverage.
Note, I'm pretty sure this isn't being run by our tests on Circle. Maybe because it's a PR from your fork? That seems strange though... At any rate, once it gets merged in, you might need to update with another PR if master is failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docstring 🐶 says: sometimes it's helpful to give little "titles" to these examples: https://github.com/plotly/python-api/blob/master/plotly/grid_objs/grid_objs.py#L29-L40
So, for yours, it might be:
Example 1: Trivial quiverExample 2: Quiver plot using meshgridExample 3: Styling the quiver plot
Quiver function plots velocity vectors and Streamline function plots
streamlines with directional arrows