add examples for customizing marker symbols #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

jdamiba merged 4 commits into doc-prod from marker-symbols

Feb 19, 2020

Merged

jdamiba merged 4 commits into doc-prod from marker-symbols

Feb 19, 2020

Conversation

Copy link

supersedes #2188 due to merge conflict issues

closes #2182


 add examples to show different symbols

5c998e6

@jdamiba jdamiba mentioned this pull request

Closed

@jdamiba jdamiba requested a review from emmanuelle

@jdamiba jdamiba changed the base branch from master to doc-prod


 fixups to figure styling

c90348e

Copy link

Contributor

Thanks @jdamiba 💃 !

Copy link

Contributor

Just two more comments from @nicolaskruchten

add text in addition to hover so that the name is displayed (without the need to hover)
use a different line and fill color as in https://rreusser.github.io/plotly-mock-viewer/#marker_symbols to show that it's possible to have different colors

emmanuelle and others added 2 commits


 Fix pytest ( #2181 )

8a1322e


 styling markers symbol example

26ef70b

Copy link

Author

@emmanuelle I have updated this PR with some of the styling suggestions that were made by @nicolas. Would love to get your opinion! FYI, we decided that it didn't look good to have the names of the symbols for the custom example always visible.
Screen Shot 2020年02月17日 at 2 16 25 PM
Screen Shot 2020年02月17日 at 2 16 13 PM