-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Fix reversed color scale issues in annotated heatmap figure factory #1251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `reversescale` does not get included into the `trace` dictionary. Therefore, color scale doesn't change when setting it to `True` (although the color of annotations gets inverted).
- pull out black/white colors as variables - Add should_use_black_text function to hold color contrast equation
Display of the figure in the new test_annotated_heatmap_reversescale test:
michaelbabyn
pushed a commit
to michaelbabyn/plotly.py
that referenced
this pull request
Dec 22, 2018
...lotly#1251) * Fix reversed color scale in annotated heatmap. Currently, `reversescale` does not get included in the `trace` dictionary. Therefore, the color scale doesn't change when setting it to `True` (although the color of annotations gets inverted). * Small refactor to pull out black/white colors as variables and add should_use_black_text function to hold color contrast equation * Handle reversescale when passing in a custom colorscale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #867. Thanks for getting this started @inguar!
In addition to the commit from #867: