-
Notifications
You must be signed in to change notification settings - Fork 1.8k
WIP: simplify interface to TWCC 4/4 #3003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
571ebf3 to
3e8b2ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #3003 +/- ## =========================================== - Coverage 77.77% 63.68% -14.10% =========================================== Files 89 67 -22 Lines 10578 3957 -6621 =========================================== - Hits 8227 2520 -5707 + Misses 1857 1308 -549 + Partials 494 129 -365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Make it possible to add interceptors at NewPeerConnection time.
Simplify the bandwidth-estimation-from-disk example to use the simplified callback-less API.
3e8b2ef to
ef9a579
Compare
Uh oh!
There was an error while loading. Please reload this page.
This is part 4/4 of a cross-repository series.
Part 1 is pion/interceptor#297
Part 2 is #3002
Part 3 is pion/interceptor#298
Please don't merge until I've had a chance to test it in Galene.
@Sean-Der Please let me know if you agree with the principle, so I can start working on making Galene use this interface. Even if you approve, I won't merge until I've convinced myself that it works for Galene.