-
Notifications
You must be signed in to change notification settings - Fork 95
feat: Sync Validor stubs with SF6.1 #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sync Validor stubs with SF6.1 #356
Conversation
Thank you.
HI @ondrejmirtes,
This (and some other feature maybe) was merge in 1.2.x but doesn't appear in any tags
https://github.com/phpstan/phpstan-symfony/releases
And there are some 1.3.x tags, but the default branch of https://github.com/phpstan/phpstan-symfony seems to be 1.2.x.
Does the 1.2.x branch should be merged into 1.3.x, the 1.3.x used as a default and a new tag done or something else ?
Thanks.
@VincentLanglet Either I need to do some branch reshuffling, or this will have to wait after PHPStan 1.11 is released this fall.
@VincentLanglet Either I need to do some branch reshuffling, or this will have to wait after PHPStan 1.11 is released this fall.
Oh, I see 1.3.2...1.2.x
Your call. I'll ignore my errors until the new release.
Thanks for the quick answer
Fix for #344
Adding method __toString() to Validator Stubs according to real Interface
I added some missing part too but I'm not sure if it can break anything in older Symfony / PHP. I can keep it to only adding method if that's needed