-
Notifications
You must be signed in to change notification settings - Fork 95
Support for ServiceProviderInterface
#252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It does not check what it should, even after removing `ServiceLocator` condition in `ContainerInterfacePrivateServiceRule` tests are green.
Accessing services from `ServiceProviderInterface` (which extends `ContainerInterface`) should not trigger "Service is private".
@ondrejmirtes @lookyman any news on this?
@ondrejmirtes @lookyman friendly ping 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this is tested by removing code from tests. Typically you should test things by adding more code?
@ondrejmirtes I described it in the PR's description 🤷♂️ I really would like to provide proper test cases, but I had hard time with that and just asked for help here.
7120655 to
931c6b5
Compare
@ondrejmirtes I've added support for
ServiceProviderInterfaceand checked it against our codebase - after my changes and implementing this interface in our locators (mentioned here) I don't have errors, so rule is working properly.But I had tough time with this mostly because of test scenario provided in #151 which IMHO does not work as expected. I started by adding
ExampleController::privateServiceFromServiceProvider()but wanted to make it fail and I couldn't. After several tries I just checked what will happen if I remove$isServiceLocatorfromContainerInterfacePrivateServiceRuleand... tests were still green. So I've just removed those services fromtests/Rules/Symfony/container.xmlcompletely and I would like to provide proper test cases for service locator/provider but I don't know how 😅 I've tried to create some example files, loaded in new test method withinContainerInterfacePrivateServiceRuleTest, but I did not manage to achieve failing scenario, which could be fixed by my changes. Could you help me with this (or @lookyman)?